dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.4 #5551

dependabot · 2025-04-07T14:14:10Z

Bumps github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.4.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.23.4

2.23.4

Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with -p in a linux container. Thanks to @emirot for the fix!

Features

Add automaxprocs for using CPUQuota [2b9c428]

Fixes

clarify gotchas about -vet flag [1f59d07]

Maintenance

bump dependencies [2d134d5]

v2.23.3

2.23.3

Fixes

allow - as a standalone argument [cfcc1a5]

Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]

ignore exit code for symbol test on linux [88e2282]

v2.23.2

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]

emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

... (truncated)

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.23.4

Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with -p in a linux container. Thanks to @emirot for the fix!

Features

Add automaxprocs for using CPUQuota [2b9c428]

Fixes

clarify gotchas about -vet flag [1f59d07]

Maintenance

bump dependencies [2d134d5]

2.23.3

Fixes

allow - as a standalone argument [cfcc1a5]

Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]

ignore exit code for symbol test on linux [88e2282]

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]

emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

2.23.0

... (truncated)

Commits

229c981 v2.23.4
2d134d5 bump dependencies
2b9c428 Add automaxprocs for using CPUQuota
31137de Revert "Add automaxprocs to automatically match the linux container CPU Quota"
91b11b8 Add automaxprocs to automatically match the linux container CPU Quota
cdfddb6 maybe escape quotes when you put them in a quoted string.
1f59d07 clarify gotchas about -vet flag
7ab7d10 bump all the things
04a9a74 v2.23.3
cfcc1a5 allow - as a standalone argument
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

k8s-ci-robot · 2025-04-07T14:14:19Z

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nawazkh · 2025-04-07T19:47:58Z

go.mod

-go 1.22.7
+go 1.23.0

-toolchain go1.22.12


Hold for CAPI driven go version update.
/hold

codecov · 2025-04-14T21:19:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.86%. Comparing base (c9ef76e) to head (df0a59e).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5551      +/-   ##
==========================================
- Coverage   52.86%   52.86%   -0.01%     
==========================================
  Files         272      272              
  Lines       29474    29474              
==========================================
- Hits        15582    15580       -2     
- Misses      13080    13082       +2     
  Partials      812      812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.22.2 to 2.23.4. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.22.2...v2.23.4) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.23.4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

mboersma

/lgtm
/approve
/hold cancel

k8s-ci-robot · 2025-04-15T12:50:06Z

LGTM label has been added.

Git tree hash: 948aa04e4cf5e8bc0c8a834fa4c528c76f0cc9b2

k8s-ci-robot · 2025-04-15T12:50:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dependabot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 7, 2025

github-project-automation bot added this to CAPZ Planning Apr 7, 2025

github-project-automation bot moved this to Todo in CAPZ Planning Apr 7, 2025

dependabot bot mentioned this pull request Apr 7, 2025

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.3 #5504

Closed

dependabot bot requested review from jackfrancis, marosset, mboersma and nojnhuh April 7, 2025 14:14

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2025

k8s-ci-robot requested a review from jsturtevant April 7, 2025 14:14

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2025

nawazkh reviewed Apr 7, 2025

View reviewed changes

go.mod Outdated

Comment on lines 3 to 5

go 1.22.7

go 1.23.0

toolchain go1.22.12

Copy link

Member

nawazkh Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold for CAPI driven go version update.
/hold

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2025

dependabot bot force-pushed the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.23.4 branch from c677a93 to dfea911 Compare April 14, 2025 21:08

dependabot bot force-pushed the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.23.4 branch from dfea911 to df0a59e Compare April 15, 2025 10:56

mboersma approved these changes Apr 15, 2025

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025

k8s-ci-robot assigned mboersma Apr 15, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025

k8s-ci-robot merged commit adc2e8d into main Apr 15, 2025
29 checks passed

k8s-ci-robot added this to the v1.20 milestone Apr 15, 2025

github-project-automation bot moved this from Todo to Done in CAPZ Planning Apr 15, 2025

dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.23.4 branch April 15, 2025 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.4 #5551

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.4 #5551

Uh oh!

dependabot bot commented on behalf of github Apr 7, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Apr 7, 2025

Uh oh!

nawazkh Apr 7, 2025

Uh oh!

codecov bot commented Apr 14, 2025 •

edited

Loading

Uh oh!

mboersma left a comment

Uh oh!

k8s-ci-robot commented Apr 15, 2025

Uh oh!

k8s-ci-robot commented Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.4 #5551

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.4 #5551

Uh oh!

Conversation

dependabot bot commented on behalf of github Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v2.23.4

2.23.4

Features

Fixes

Maintenance

v2.23.3

2.23.3

Fixes

v2.23.2

2.23.2

v2.23.1

2.23.1

🚨 For users on MacOS 🚨

Fixes

2.23.4

Features

Fixes

Maintenance

2.23.3

Fixes

2.23.2

2.23.1

🚨 For users on MacOS 🚨

Fixes

2.23.0

Uh oh!

k8s-ci-robot commented Apr 7, 2025

Uh oh!

nawazkh Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mboersma left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 15, 2025

Uh oh!

k8s-ci-robot commented Apr 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dependabot bot commented on behalf of github Apr 7, 2025 •

edited

Loading

codecov bot commented Apr 14, 2025 •

edited

Loading